Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump ruff to v0.8 #6634

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Bump ruff to v0.8 #6634

wants to merge 4 commits into from

Conversation

danielhollas
Copy link
Collaborator

Builds on top of #6614, which should be reviewed and merged first.

I've pushed this as a separate PR for easier review. Marking this as draft until then.

Most of the changes here come from a new rule RUF022

 unsorted-dunder-all (RUF022)

Derived from the **Ruff-specific rules** linter.

Fix is sometimes available.

## What it does
Checks for `__all__` definitions that are not ordered
according to an "isort-style" sort.

An isort-style sort orders items first according to their casing:
SCREAMING_SNAKE_CASE names (conventionally used for global constants)
come first, followed by CamelCase names (conventionally used for
classes), followed by anything else. Within each category,
a [natural sort](https://en.wikipedia.org/wiki/Natural_sort_order)
is used to order the elements.

@unkcpz unkcpz self-requested a review November 27, 2024 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@unkcpz unkcpz Awaiting requested review from unkcpz

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@danielhollas